Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 1.x] Add tooltip to help icon #3871

Merged

Conversation

abbyhu2000
Copy link
Member

Add tooltip to menu icon
Manual backport of #3626

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Apr 17, 2023
@abbyhu2000 abbyhu2000 marked this pull request as ready for review April 17, 2023 23:45
@ananzh ananzh changed the title [Manual Backport 1.x] Backport/backport 3626 to 1.x [Manual Backport 1.x] Add tooltip to help icon Apr 17, 2023
ananzh
ananzh previously approved these changes Apr 17, 2023
* Add tooltip to help icon

Signed-off-by: sabina.zaripova <[email protected]>

Add tooltip to menu icon

Signed-off-by: sabina.zaripova <[email protected]>
@abbyhu2000 abbyhu2000 force-pushed the backport/backport-3626-to-1.x branch from bd62d85 to 2b004ac Compare April 17, 2023 23:57
@joshuarrrr joshuarrrr added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Apr 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3871 (2b004ac) into 1.x (637d545) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.x    #3871      +/-   ##
==========================================
+ Coverage   67.45%   67.50%   +0.04%     
==========================================
  Files        3044     3044              
  Lines       58692    58692              
  Branches     8902     8902              
==========================================
+ Hits        39593    39619      +26     
+ Misses      16946    16925      -21     
+ Partials     2153     2148       -5     
Flag Coverage Δ
Linux 67.45% <ø> (ø)
Windows 67.45% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/core/public/chrome/ui/header/header.tsx 71.42% <ø> (ø)
.../core/public/chrome/ui/header/header_help_menu.tsx 31.81% <ø> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ashwin-pc ashwin-pc merged commit 610542f into opensearch-project:1.x Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v1.3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants